Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move modal top spacing to the header to avoid side-effect when scrolling #2587

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Move modal top spacing to the header to avoid side-effect when scrolling #2587

merged 1 commit into from
Nov 24, 2020

Conversation

juliushaertl
Copy link
Member

Fixes #2575

@juliushaertl juliushaertl added this to the 1.2.2 milestone Nov 19, 2020
stefan-niedermann
stefan-niedermann approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@juliushaertl juliushaertl merged commit 61537b1 into master Nov 24, 2020
@juliushaertl juliushaertl deleted the bugfix/2575 branch November 24, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-niedermann stefan-niedermann stefan-niedermann approved these changes

@jakobroehrl jakobroehrl Awaiting requested review from jakobroehrl

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

Content of modal view shines through header when scrolling
2 participants
@juliushaertl @stefan-niedermann